Arm backend: Eliminate dead shape ops#18902
Merged
oscarandersson8218 merged 1 commit intopytorch:mainfrom Apr 15, 2026
Merged
Conversation
Shape ops get their dim_order from their users. If a shape-op does not have any users, it will therefore not get a dim_order and crash during serialization. To avoid this, we can simply delete any unused shape op from the graph before serialzation. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I06cfb68056294e6dbf1d69129645130d4fb8c952
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18902
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 3 Unrelated FailuresAs of commit 9430708 with merge base 87e65ac ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
zingo
approved these changes
Apr 15, 2026
Collaborator
Author
|
Unrelated failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shape ops get their dim_order from their users. If a shape-op does not have any users, it will therefore not get a dim_order and crash during serialization. To avoid this, we can simply delete any unused shape op from the graph before serialization.
cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell